Ontology meeting 2020-02-03: Difference between revisions

From GO Wiki
Jump to navigation Jump to search
 
(23 intermediate revisions by 3 users not shown)
Line 2: Line 2:
See calendar for details
See calendar for details


On call:  
On call: Harold, David, Peter, Barbara, Jim, Karen, Kimberly, Pascale, Chris, Tanya, Bill
 
Note David will not be here next week. We will need someone else to host this call.


= Agenda =
= Agenda =


==Discussion topics==
==Discussion topics==
===Issue tracker rota===
Lately there have been a large number of tickets open in the areas of immunology and organism-interaction; so many that it has become a project in and of itself. Since Pascale is the only one comfortable editing this area of the ontology, it has effectively removed her from the rota. This means that there are only two editors working on tickets for all other request, David and Harold. Everyone else is off the rota and assigned to projects. In addition Harold and David have projects on which they are supposed to be working. What can we do about this?


===Aligning Ontology, Annotation, ShEx===
===Aligning Ontology, Annotation, ShEx===
Line 18: Line 24:


====GOREL relations that could potentially be retired and replaced with existing RO relations====
====GOREL relations that could potentially be retired and replaced with existing RO relations====
*ACTION: As a pilot, David and Kimberly replaced 'occurs in' in cell division logical definitions with 'has input' for specific cell types
*https://github.com/geneontology/go-ontology/pull/18690
*Also removed some asserted parents for cell division terms - this changed some parentage wrt neuroblasts and somatic stem cell parentage (but is now consistent with CL)
*Entered a ticket in the CL tracker, for which David OS has made some updates https://github.com/obophenotype/cell-ontology/issues/617 pull request needs review
*Overall, this wasn't too difficult and we could continue along these lines for the other relations in question (results in fission of, results in fusion of, results in maintenance of, results in distribution of) although these are not of highest priority since they haven't been used in annotation
From 2020-01-27 call:
====='results in division of' (GOREL:0001019)=====
====='results in division of' (GOREL:0001019)=====
*Not used in the ontology
*Not used in the ontology
Line 28: Line 40:
*For annotation, it looks like curators use 'occurs in', 'has participant, 'results in division of' although there aren't many annotation extensions at all for 'cell division' and children
*For annotation, it looks like curators use 'occurs in', 'has participant, 'results in division of' although there aren't many annotation extensions at all for 'cell division' and children


*PROPOSED ACTION: review and update annotations to use 'has input' (create go-annotation ticket - couldn't find one already)
**Note that we will need to update the local range for 'has input' to allow for cells before doing this
*PROPOSED ACTION: obsolete 'results in division of' see https://github.com/geneontology/go-ontology/issues/18804
*PROPOSED ACTION: keep 'regulates o results in division of' for now
***fate of the chained relations is still undecided
***we have a model for importing them
***we haven't decided on exporting them, but are leaning towards not doing that
*PROPOSED ACTION: create a design pattern for cell division using 'has input'


*GO
=====localization and transporter activity shapes=====
  [Typedef]
*Review proposed shape for [https://docs.google.com/document/d/1qTRlvj1NDRMs4zf4odDa0CDvX5L-LYecO1jyqdEvAVA localization]
  id: results_in_division_of
**what about multi-organism localization (GO:1902579) defined as: localization AND ('bearer of' some 'multi-organismal process quality')
  name: results_in_division_of
***note that 'bearer of' is not in the ShEx
  namespace: external
  comment: use occurs_in
  xref: GOREL:0001019
  is_a: has_participant ! has participant
 
*GOREL
[Typedef]
id: results_in_division_of
name: results_in_division_of
namespace: go/extensions/gorel
def: "The relationship linking a entity and its participation in a process that results in the division of the entity into two entities of the same type." [GOC:mtg_berkeley_2013]
comment: Example of use: an annotation of gene X to cell division with results_in_division_of CL:0000057 (fibroblast) means that at the end of the process a single fibroblast has divided into two fibroblasts.
subset: AE_cell_or_anatomical
subset: display_for_curators
subset: valid_for_annotation_extension
xref: GOREL:0001019
property_value: local_domain BFO:0000015 xsd:string
property_value: local_range "CL:0000000 WBbt:0004017" xsd:string
property_value: usage "The relationship linking a entity and its participation in a process that results in the division of the entity into two entities of the same type." xsd:string
domain: BFO:0000015
range: CL:0000000
is_a: go_annotation_extension_relation ! go annotation extension relation
is_a: has_participant ! has participant
 
 
*regulates_o_results_in_division_of
**Not used in the ontology
**For annotation, it looks like curators use 'regulates o has participant', 'regulates o results in division of' although there are very few of these annotations


[Typedef]
===Follow-up from 2020-01-28 annotation call===
  id: regulates_o_results_in_division_of
====Binding terms====
name: regulates division of
*Curators asked for firm guidelines on when to request new 'binding' terms
namespace: go/extensions/gorel
*Can we get back to them with a proposal? For example:
def: "This is the combination of the regulates relation with the results_in_division_of relation." [GOC:mtg_berkeley_2013]
**Going forward, curators will annotate binding using an appropriately general genus term (TBD) and the 'has input' extension for the chemical entity
subset: display_for_curators
**We can generate monthly reports of annotation extension use to see if there are any highly (TBD) used extensions for which we should create ontology terms
subset: valid_for_annotation_extension
**Things to consider:
xref: GOREL:0001024
***For chemical entities, what ontology terms should curators use?
property_value: local_domain GO:0008150 xsd:string
***What should we do with existing terms in the ontology?
property_value: local_range "CL:0000000 WBbt:0004017" xsd:string
***We still need to convey what binding events we want to capture as MFs, and why, in GO
property_value: usage "This is the combination of the regulates relation with the results_in_division_of relation." xsd:string
====Compound functions and molecular function regulators====
domain: BFO:0000015
*We need to decide on a design pattern for compound functions
is_a: go_annotation_extension_relation ! go annotation extension relation
*For the estrogen nuclear receptor, the demo GO-CAM model had estrogen binding 'directly positively regulates' nuclear receptor activity
is_a: regulates_o_has_participant ! regulates_o_has_participant
*This results in an inferred molecular function regulator annotation on the estrogen binding node meaning that the estrogen receptor is a molecular function regulator of itself, which curators felt was not biologically correct/intuitive and they wouldn't want to show this to users
equivalent_to_chain: regulates results_in_division_of ! results_in_division_of
*Can we model compound functions with 'has part' in the ontology rather than a regulatory relation between the separate functions?


*PROPOSED ACTION: obsolete 'results in division of' and 'regulates o results in division of'
*Note that we will still get many inferred molecular function regulator MF annotations for models where we use the 'directly positively/negatively regulates' relation between two activities 'enabled by' different gene products
*Replacement:
*Do we still want molecular function regulator as an MF class in the ontology?  Should we keep its logical definition?
**PROPOSAL 1: use 'occurs in' for logical definitions and to provide context in annotation for what cell is dividing and 'regulates o occurs in' for standard regulation annotations
*Do we want to export inferred molecular function regulator annotations, even for upstreams gps who activity directly regulates that of downstream gps?
**PROPOSAL 2: use 'has input' and 'has output' for logical definitions and to provide context in annotation for what cell is dividing and what cells that division produces and 'regulates o has input', 'regulates o has output' for standard regulation annotations
**PROPOSAL 3: some hybrid of the above 'occurs in' and 'has input' and 'has output'?
*PROPOSED ACTION: create a design pattern


====Inferred Protein Binding Annotations====
*We still get inferred protein binding annotations when connecting two MFs with a directly positively regulates relation and the second MF is enabled by a protein entity
*Change SWRL rule?


====BPs of type 'regulation of MF'====
(Pascale): Are we still creating terms like 'regulation of poly(A)-specific ribonuclease activity' (see https://github.com/geneontology/go-ontology/issues/16793). I thought this was now captured as MF 'enzyme regulator activity'. Can we make a decision on that ?


==Other Business==
==Other Business==

Latest revision as of 13:07, 10 February 2020

Conference Line

See calendar for details

On call: Harold, David, Peter, Barbara, Jim, Karen, Kimberly, Pascale, Chris, Tanya, Bill

Note David will not be here next week. We will need someone else to host this call.

Agenda

Discussion topics

Issue tracker rota

Lately there have been a large number of tickets open in the areas of immunology and organism-interaction; so many that it has become a project in and of itself. Since Pascale is the only one comfortable editing this area of the ontology, it has effectively removed her from the rota. This means that there are only two editors working on tickets for all other request, David and Harold. Everyone else is off the rota and assigned to projects. In addition Harold and David have projects on which they are supposed to be working. What can we do about this?

Aligning Ontology, Annotation, ShEx

  • We are creating ontology term-specific shapes in the ShEx schema
  • The goal is to align what is used for annotation with the equivalent expression in logical definitions of the ontology
  • We are also moving towards only using RO relations in GO, i.e. retiring, or incorporating into RO, GOREL relations or RO-pending relations

GOREL relations proposed to RO

GOREL relations that could potentially be retired and replaced with existing RO relations

  • ACTION: As a pilot, David and Kimberly replaced 'occurs in' in cell division logical definitions with 'has input' for specific cell types
  • https://github.com/geneontology/go-ontology/pull/18690
  • Also removed some asserted parents for cell division terms - this changed some parentage wrt neuroblasts and somatic stem cell parentage (but is now consistent with CL)
  • Entered a ticket in the CL tracker, for which David OS has made some updates https://github.com/obophenotype/cell-ontology/issues/617 pull request needs review
  • Overall, this wasn't too difficult and we could continue along these lines for the other relations in question (results in fission of, results in fusion of, results in maintenance of, results in distribution of) although these are not of highest priority since they haven't been used in annotation

From 2020-01-27 call:

'results in division of' (GOREL:0001019)
  • Not used in the ontology
    • In the ontology, logical definitions use:
      • 'occurs in', e.g. cystoblast division = cell division and 'occurs in' some cystoblast
      • 'has input', e.g. germ-line stem cell division = cell division and 'has input' some germ-line stem cell
      • loosely, but not exclusively, along somatic vs stem cell lines
    • No design pattern (that I could find)
  • For annotation, it looks like curators use 'occurs in', 'has participant, 'results in division of' although there aren't many annotation extensions at all for 'cell division' and children
  • PROPOSED ACTION: review and update annotations to use 'has input' (create go-annotation ticket - couldn't find one already)
    • Note that we will need to update the local range for 'has input' to allow for cells before doing this
  • PROPOSED ACTION: obsolete 'results in division of' see https://github.com/geneontology/go-ontology/issues/18804
  • PROPOSED ACTION: keep 'regulates o results in division of' for now
      • fate of the chained relations is still undecided
      • we have a model for importing them
      • we haven't decided on exporting them, but are leaning towards not doing that
  • PROPOSED ACTION: create a design pattern for cell division using 'has input'
localization and transporter activity shapes
  • Review proposed shape for localization
    • what about multi-organism localization (GO:1902579) defined as: localization AND ('bearer of' some 'multi-organismal process quality')
      • note that 'bearer of' is not in the ShEx

Follow-up from 2020-01-28 annotation call

Binding terms

  • Curators asked for firm guidelines on when to request new 'binding' terms
  • Can we get back to them with a proposal? For example:
    • Going forward, curators will annotate binding using an appropriately general genus term (TBD) and the 'has input' extension for the chemical entity
    • We can generate monthly reports of annotation extension use to see if there are any highly (TBD) used extensions for which we should create ontology terms
    • Things to consider:
      • For chemical entities, what ontology terms should curators use?
      • What should we do with existing terms in the ontology?
      • We still need to convey what binding events we want to capture as MFs, and why, in GO

Compound functions and molecular function regulators

  • We need to decide on a design pattern for compound functions
  • For the estrogen nuclear receptor, the demo GO-CAM model had estrogen binding 'directly positively regulates' nuclear receptor activity
  • This results in an inferred molecular function regulator annotation on the estrogen binding node meaning that the estrogen receptor is a molecular function regulator of itself, which curators felt was not biologically correct/intuitive and they wouldn't want to show this to users
  • Can we model compound functions with 'has part' in the ontology rather than a regulatory relation between the separate functions?
  • Note that we will still get many inferred molecular function regulator MF annotations for models where we use the 'directly positively/negatively regulates' relation between two activities 'enabled by' different gene products
  • Do we still want molecular function regulator as an MF class in the ontology? Should we keep its logical definition?
  • Do we want to export inferred molecular function regulator annotations, even for upstreams gps who activity directly regulates that of downstream gps?

Inferred Protein Binding Annotations

  • We still get inferred protein binding annotations when connecting two MFs with a directly positively regulates relation and the second MF is enabled by a protein entity
  • Change SWRL rule?

BPs of type 'regulation of MF'

(Pascale): Are we still creating terms like 'regulation of poly(A)-specific ribonuclease activity' (see https://github.com/geneontology/go-ontology/issues/16793). I thought this was now captured as MF 'enzyme regulator activity'. Can we make a decision on that ?

Other Business

https://github.com/geneontology/go-ontology/projects/1

Minutes should be recorded on individual tickets and in individual projects